Refactor git providers (#438)

* Refactor git providers

- use a different cache set for each Describe section
- moved repo validation to the main function that creates it
- use h.GetAccountType anywhere

* removed unused function

* removed unused provider variable

* fixed recorder url filter, updated cache

* Fixed Bad Credentials error

Other tests were changing the GITHUB_TOKEN env variable so when those tests run before git providers tests it was causing Bad Credentials errors when running locally.

* added missing cache file

pkg/gitproviders/common.go

@@ -119,12 +119,6 @@ func (h defaultGitProviderHandler) CreateRepository(name string, owner string, p
 		}
 	}
 
-	if err = utils.WaitUntil(os.Stdout, time.Second, time.Second*30, func() error {
-		return GetRepoInfo(githubProvider, ownerType, owner, name)
-	}); err != nil {
-		return fmt.Errorf("could not verify repo existence %s", err)
-	}
-
 	return nil
 }
 
@@ -137,7 +131,7 @@ func (h defaultGitProviderHandler) DeployKeyExists(owner, repoName string) (bool
 
 	deployKeyName := "weave-gitops-deploy-key"
 
-	ownerType, err := GetAccountType(owner)
+	ownerType, err := h.GetAccountType(owner)
 	if err != nil {
 		return false, err
 	}
@@ -215,7 +209,7 @@ func (h defaultGitProviderHandler) UploadDeployKey(owner, repoName string, deplo
 		if err != nil {
 			return fmt.Errorf("error uploading deploy key %s", err)
 		}
-		if err = utils.WaitUntil(os.Stdout, time.Second, time.Second*10, func() error {
+		if err = utils.WaitUntil(os.Stdout, time.Second, time.Second*30, func() error {
 			_, err = orgRepo.DeployKeys().Get(ctx, deployKeyName)
 			return err
 		}); err != nil {
@@ -232,7 +226,7 @@ func (h defaultGitProviderHandler) UploadDeployKey(owner, repoName string, deplo
 		if err != nil {
 			return fmt.Errorf("error uploading deploy key %s", err)
 		}
-		if err = utils.WaitUntil(os.Stdout, time.Second, time.Second*10, func() error {
+		if err = utils.WaitUntil(os.Stdout, time.Second, time.Second*30, func() error {
 			_, err = userRepo.DeployKeys().Get(ctx, deployKeyName)
 			return err
 		}); err != nil {
@@ -268,10 +262,6 @@ func CreatePullRequestToOrgRepo(orgRepRef gitprovider.OrgRepositoryRef, targetBr
 	return gitProviderHandler.(GitProviderHandler).CreatePullRequestToOrgRepo(orgRepRef, targetBranch, newBranch, files, commitMessage, prTitle, prDescription)
 }
 
-func GetAccountType(owner string) (ProviderAccountType, error) {
-	return gitProviderHandler.(GitProviderHandler).GetAccountType(owner)
-}
-
 func (h defaultGitProviderHandler) GetAccountType(owner string) (ProviderAccountType, error) {
 	provider, err := GithubProvider()
 	if err != nil {
@@ -353,7 +343,7 @@ func CreateOrgRepository(provider gitprovider.Client, orgRepoRef gitprovider.Org
 		return fmt.Errorf("error creating repo %s", err)
 	}
 
-	return nil
+	return waitUntilRepoCreated(AccountTypeOrg, orgRepoRef.Organization, orgRepoRef.RepositoryName)
 }
 
 func CreateUserRepository(provider gitprovider.Client, userRepoRef gitprovider.UserRepositoryRef, repoInfo gitprovider.RepositoryInfo, opts ...gitprovider.RepositoryCreateOption) error {
@@ -365,7 +355,7 @@ func CreateUserRepository(provider gitprovider.Client, userRepoRef gitprovider.U
 		return fmt.Errorf("error creating repo %s", err)
 	}
 
-	return nil
+	return waitUntilRepoCreated(AccountTypeUser, userRepoRef.UserLogin, userRepoRef.RepositoryName)
 }
 
 func Override(handler GitProviderHandler) override.Override {
@@ -485,3 +475,12 @@ func NewUserRepositoryRef(domain, user, repoName string) gitprovider.UserReposit
 		},
 	}
 }
+
+func waitUntilRepoCreated(ownerType ProviderAccountType, owner, name string) error {
+	if err := utils.WaitUntil(os.Stdout, time.Second, time.Second*30, func() error {
+		return GetRepoInfo(githubProvider, ownerType, owner, name)
+	}); err != nil {
+		return fmt.Errorf("could not verify repo existence %s", err)
+	}
+	return nil
+}