-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor git providers #438
Conversation
- use a different cache set for each Describe section - moved repo validation to the main function that creates it - use h.GetAccountType anywhere
Other tests were changing the GITHUB_TOKEN env variable so when those tests run before git providers tests it was causing Bad Credentials errors when running locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would it be possible at some point to add a comment explaining how to generate the cache files?
Do we still need to manually edit the cache files after generate them? |
Sorry man, I'm confused. Why would we need to do something like that?. I probably know where the confusion is, though. Even though this runs as part of the unit tests job. I would like to see this as some sort of mix between unit tests and integration tests. Let's have a further discussion about this when I add documentation to clarify how this works in a follow up PR. |
# Conflicts: # pkg/gitproviders/common_test.go
What changed?
Why?
-- The URL filter was not replacing values properly.
-- When generating cache sometimes it was throwing Bad Credentials errors due to conflicts with other tests modifying GITHUB_TOKEN env variable.
How did you test it?