-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gitops get profiles
command
#1227
Conversation
gitops get profiles
command
ac9f2f7
to
67521b5
Compare
3472e1e
to
a419151
Compare
return err | ||
} | ||
|
||
return profiles.GetProfiles(context.Background(), profiles.GetOptions{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this works, it relies on having access to the cluster through the kubeconfig and bypasses the config repo, which should be the Gitops SoT. I guess this is one way but not the only way that we want to be able to get profiles (maybe we need a separate ticket)? cc @bigkevmcd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gitops SoT.
what does this mean 🤔
I guess this is one way but not the only way that we want to be able to get profiles (maybe we need a separate ticket)? cc @bigkevmcd
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
basically I'm wondering whether it's better to list the profiles that are in the cluster through the local kubeconfig or through the HelmRelease
s in /.weave-gitops/clusters/<cluster name>/system
, or both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is listing available profiles, as in what you can install (the charts that are availble from the HelmRepository
resource), not what you've actually got installed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there are three possible lists of Profiles...
- List of Profiles in a cluster directory in a Git repository
- List of available profiles (to be installed)
- List of installed profiles in the cluster pointed at by your current context
So, we need to figure out how to be able to query for these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This story/PR is definitely just for 2.
, but I agree we will need 1.
and 3.
at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good! @Himangini and I will link up on Monday to create some follow-up tickets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess there are three possible lists of Profiles...
- List of Profiles in a cluster directory in a Git repository
- List of available profiles (to be installed)
- List of installed profiles in the cluster pointed at by your current context
So, we need to figure out how to be able to query for these
This should've been discussed in planning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This story/PR is definitely just for
2.
, but I agree we will need1.
and3.
at some point
@aclevername can you pair with @bigkevmcd and come up with tickets for 1.
and 3.
with details of what's required, please. Please also link this PR for reference in the new ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
5f65aa3
to
77ad36f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does what it should 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (go.mod
needs updating, hopefully that resolves the Snyk issue)
Closes: #1108
What changed?
New command:
To be able to see the available profiles
How did you test it?
Manually & acceptance test
Release notes
Add new
gitops get profiles
command for discovering available profilesDocumentation Changes
TODO