Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes upgrade command #1297

Merged
merged 10 commits into from Jan 17, 2022
Merged

Fixes upgrade command #1297

merged 10 commits into from Jan 17, 2022

Conversation

foot
Copy link
Contributor

@foot foot commented Jan 13, 2022 •
edited

Closes:

What changed?

  • gitops upgrade now modifies the kustomization.yaml file to include the new manifests
  • clarify how to provide extra overrides when upgrading
  • auto-detect default branch
  • remove wego-app.yaml deployment if we can find it, otherwise continue with a warning

Why?

Behaviour was modified in #1141 to now include a kustomization.yaml

How did you test it?

  • manually
  • more tests

Release notes

Documentation Changes

@foot foot marked this pull request as ready for review January 13, 2022 18:39
yiannistri
yiannistri approved these changes Jan 13, 2022
View reviewed changes
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor suggestions but otherwise this LGTM 🥇

pkg/server/profiles.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
foot
foot commented Jan 13, 2022
View reviewed changes
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
pkg/server/profiles.go Outdated Show resolved Hide resolved
pkg/upgrade/upgrade.go Outdated Show resolved Hide resolved
@foot foot merged commit e9b3a65 into main Jan 17, 2022
@foot foot deleted the fixes-upgrade-command branch January 17, 2022 11:32
This was referenced Jan 17, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiannistri yiannistri yiannistri approved these changes

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foot @yiannistri