Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrades to a ggp w/ the on-prem-gitlab fix #1309

Merged
merged 4 commits into from Jan 18, 2022
Merged

Upgrades to a ggp w/ the on-prem-gitlab fix #1309

merged 4 commits into from Jan 18, 2022

Conversation

foot
Copy link
Contributor

@foot foot commented Jan 17, 2022 •
edited

What changed?

Why?

For on-prem things!

How did you test it?

gitops upgrade before:

Error: failed to get git clients: error setting up deploy keys: failed check for existing deploy key: error getting user repo reference for owner XXXX, repo demo-01, error getting user repository domai
n "https://XXXX" not supported by this client: the client doesn't support handling requests for this domain

yiannistri
yiannistri approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@foot foot merged commit fdd7ffa into main Jan 18, 2022
@foot foot deleted the fixes-on-prem-gitlab branch January 18, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiannistri yiannistri yiannistri approved these changes

Assignees
No one assigned
Labels
exclude from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@foot @yiannistri