Add Filtering Structure for Data Table #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpellizzari
reviewed
Feb 14, 2022
ui/components/FilterBar.tsx
Outdated
| } | ||
|
|
||
| const FilterBar = styled(UnstyledFilterBar).attrs({ | ||
| className: UnstyledFilterBar.name, |
There was a problem hiding this comment.
This name is not going to make sense as a className. Can I recommend we do this?:
export default styled(FilterBar).attrs({ className: FilterBar.name })``;
There was a problem hiding this comment.
The ONLY reason I'm doing it like that is for Storybook to work correctly and automatically. It's definitely ugly and I hate it but I haven't found a way for Storybook to import things automatically otherwise.
There was a problem hiding this comment.
OK lets change the attrs.className to be a semantic name, ie FilterBar
jpellizzari
reviewed
Feb 15, 2022
jpellizzari
approved these changes
Feb 16, 2022
ui/components/FilterBar.tsx
Outdated
| const [anchorEl, setAnchorEl] = React.useState(null); | ||
| const [showFilters, setShowFilters] = React.useState(false); | ||
|
|
||
| const onCheck = (e, option) => { |
There was a problem hiding this comment.
Can we get some type annotations here? What will e and option look like when they get passed in here?
| case IconType.SearchIcon: | ||
| return SearchIcon; | ||
|
|
||
| case IconType.ClearIcon: |
There was a problem hiding this comment.
Merge conflict incoming from this PR: #1451
| ); | ||
| expect(screen.queryByText("app")).toBeTruthy(); | ||
| expect(screen.queryByText("app3")).toBeTruthy(); | ||
| expect(screen.queryByText("Clear All")).toBeTruthy(); |
jpellizzari
pushed a commit
that referenced
this pull request
Feb 25, 2022
* added outside parts, now working on inside parts * filter bar v1 * updated tests * hitting pause on this awaiting design changes * separated out chips into chip group, addressed pr comments, changing styling to new design * styles and tests * readded icons
jpellizzari
pushed a commit
that referenced
this pull request
Mar 3, 2022
* added outside parts, now working on inside parts * filter bar v1 * updated tests * hitting pause on this awaiting design changes * separated out chips into chip group, addressed pr comments, changing styling to new design * styles and tests * readded icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets up a filtering component to be used in parent component of
<DataTable />- functionality will be passed down. I'm fully expecting to have to add some styling polish. so hit me with what needs to change.Check it out by pulling down the
filter-barbranch and runningnpm run storybook