Add releases and flux runtime pages #1451

jpellizzari · 2022-02-15T23:16:15Z

Adds the list pages according to the provided designs https://www.figma.com/file/IVHnM9iyeFWpd11evtY8ux/Weave-GitOps?node-id=5399%3A12874

Releases/Applications:

Sources Page:

Flux Runtime:

Note that this branch will not work for local development because of other broken things on v2. See this patch for more details: https://gist.github.com/jpellizzari/115de69875911c37cb6b0c0edc38e20c

JamWils · 2022-02-15T23:26:42Z

api/app/apps.proto

@@ -119,7 +119,7 @@ service Apps {
    */
  rpc ListKustomizations(ListKustomizationsReq) returns (ListKustomizationsRes) {
    option (google.api.http) = {
-      get : "/v1/namespace/{namespace}/app/{app_name}/kustomization"
+      get : "/v1/kustomizations"


Nit: should this be plural? Usually the REST semantics are /v1/kustomization, I would expect a list. Then /v1/kustomization/:id, I would expect to get one.

Sure, but not sure why we would try to min/max this as a REST API. I would hope someone would use the open API output to generate a client library in their language of choice.

We already gen the go and ts clients. I didn't have to change anything in my "user space" code to accommodate this change.

sympatheticmoose · 2022-02-16T12:07:34Z

Good progress being made 👍 thanks Jordan

Some comments:
Applications page

Types should be kustomization / Helm Release rather than kustomize
Source in the designs doesn't show the type, but actually I'm ok with it cc @bia
Missing filters (assuming follow up PR)
Name is only one with sort arrow, is this easy to add to other columns?

Sources page

should be sub-menu item under Applications similar to Clusters > templates in WGE.
Types should be Git Repository / Helm Repository / Bucket (i.e. not just Git)
Missing Reference (currently marked as Release in Figma)
Designs are yet to address comments/reflect the doc in notion and as such are missing cluster, namespace and interval/last synced

Flux Runtime page

Image not Images
Default should sort by Cluster.

jpellizzari · 2022-02-16T18:46:02Z

@sympatheticmoose

Types should be kustomization / Helm Release rather than kustomize

Fixed

Missing filters (assuming follow up PR)

@joshri is working on that

Name is only one with sort arrow, is this easy to add to other columns?

Fixed

Sources page

should be sub-menu item under Applications similar to Clusters > templates in WGE.

Follow up created: #1459

Types should be Git Repository / Helm Repository / Bucket (i.e. not just Git)

Fixed

Missing Reference (currently marked as Release in Figma)

Added, but we need to think about what this means for Helm/Bucket

Designs are yet to address comments/reflect the doc in notion and as such are missing cluster, namespace and interval/last synced

Interval added

Flux Runtime page

Image not Images

Fixed, but a Deployment can have multiple images.

Default should sort by Cluster.

Added

sympatheticmoose · 2022-02-17T10:55:27Z

Many thanks @jpellizzari

Added, but we need to think about what this means for Helm/Bucket

Both still have status.artifact.revision or do you feel this isn't valuable/there's something else we should look to show?

Fixed, but a Deployment can have multiple images.

Fair point, I wouldn't expect the flux controllers to though? Or am I missing something?

luizbafilho · 2022-02-17T14:20:00Z

core/server/app.go

+
+	list := &appsv1.DeploymentList{}
+
+	if err := k8s.List(ctx, list, client.InNamespace(msg.Namespace)); err != nil {


I think we should avoid making assumptions about flux namespace (https://github.com/weaveworks/weave-gitops/pull/1451/files#diff-35acf2adc3a7b1021fb41d3473b47e030d3708ba2e8ff7a4b76c13ee80b4076cR42) and grab it by using something like: https://github.com/weaveworks/weave-gitops/blob/v2/pkg/kube/kubehttp.go#L496

I'm not sure we want to keep that interface but the actual method is useful.

@luizbafilho Since we allow the client to specify the namespace, can I fetch the correct namespace in a different call (in a future PR)?

Yeah, it would be a good follow up issue

joshri

Front end looks stunning but I'll leave the approval to the back end experts

@sympatheticmoose are all sortable fields intended to have a sort arrow? Right now only the field that is actively being sorted has one

joshri · 2022-02-17T15:39:24Z

ui/components/KubeStatusIndicator.tsx

+
+export default styled(KubeStatusIndicator).attrs({
+  className: KubeStatusIndicator.name,
+})``;


💕 ❤️ 💕

@sympatheticmoose are all sortable fields intended to have a sort arrow? Right now only the field that is actively being sorted has one

I believe that is the design... @bia could you confirm? I am assuming the column header is clickable and thats what applies/flips the sort?

Yes, in the current design only the field that is actively being sorted has an arrow (facing up or down based on sort direction). The other column headers that can sort the table should be clickable and the sort would be applied on click.

joshri · 2022-02-17T15:42:14Z

ui/pages/v2/ApplicationList/ApplicationList.tsx

+          "type",
+          "cluster",
+          "status",
+          "last synced at",


I'm curious if my sort is handling "last synced at" correctly...

Probs not; we will need to add the concept of data types.

JamWils reviewed Feb 15, 2022

View reviewed changes

jpellizzari force-pushed the jp-v2-releases-page branch 2 times, most recently from 56aa620 to 6e2a446 Compare February 16, 2022 19:06

jpellizzari marked this pull request as ready for review February 16, 2022 19:07

jpellizzari requested review from joshri, luizbafilho and josecordaz February 16, 2022 19:08

jpellizzari mentioned this pull request Feb 16, 2022

Add Filtering Structure for Data Table #1436

Merged

jpellizzari force-pushed the jp-v2-releases-page branch 3 times, most recently from d4e11c3 to c3c8d36 Compare February 16, 2022 21:07

jpellizzari added 2 commits February 16, 2022 13:08

Add automations list

3f83763

Add FluxRuntime handler and UI

65799bf

jpellizzari force-pushed the jp-v2-releases-page branch from c3c8d36 to 65799bf Compare February 16, 2022 21:08

Delete 0001-Fix-bad-wego-app-permissions-and-silence-profiles.patch

41b6d51

luizbafilho reviewed Feb 17, 2022

View reviewed changes

joshri reviewed Feb 17, 2022

View reviewed changes

jpellizzari mentioned this pull request Feb 17, 2022

Create endpoint for fetching the flux namespace #1465

Closed

luizbafilho approved these changes Feb 17, 2022

View reviewed changes

joshri self-requested a review February 17, 2022 16:14

joshri approved these changes Feb 17, 2022

View reviewed changes

jpellizzari merged commit c8c743f into v2 Feb 17, 2022

jpellizzari deleted the jp-v2-releases-page branch February 17, 2022 16:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add releases and flux runtime pages #1451

Add releases and flux runtime pages #1451

jpellizzari commented Feb 15, 2022 •

edited

JamWils Feb 15, 2022

jpellizzari Feb 15, 2022

sympatheticmoose commented Feb 16, 2022

jpellizzari commented Feb 16, 2022 •

edited

sympatheticmoose commented Feb 17, 2022

luizbafilho Feb 17, 2022

jpellizzari Feb 17, 2022

luizbafilho Feb 17, 2022

jpellizzari Feb 17, 2022

joshri left a comment

joshri Feb 17, 2022

sympatheticmoose Feb 18, 2022 •

edited

bia Feb 22, 2022

joshri Feb 17, 2022

jpellizzari Feb 17, 2022

jpellizzari Feb 17, 2022


		list := &appsv1.DeploymentList{}

		if err := k8s.List(ctx, list, client.InNamespace(msg.Namespace)); err != nil {

Add releases and flux runtime pages #1451

Add releases and flux runtime pages #1451

Conversation

jpellizzari commented Feb 15, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sympatheticmoose commented Feb 16, 2022

jpellizzari commented Feb 16, 2022 • edited

sympatheticmoose commented Feb 17, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshri left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sympatheticmoose Feb 18, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jpellizzari commented Feb 15, 2022 •

edited

jpellizzari commented Feb 16, 2022 •

edited

sympatheticmoose Feb 18, 2022 •

edited