Upgrade weaveworks/go-checkpoint to version with go.mod #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozamosi
force-pushed
the
go-mod-checkpoint
branch
from
ce1227f
to
c7b2009
Compare
This upgrade changes no code at all, so it _should_ be safe. This is a bit of a stab in the dark to try to get the snyk github integration working (part of #1503) - apparently we can't have dependencies without go.mod files?
ozamosi
force-pushed
the
go-mod-checkpoint
branch
from
c7b2009
to
813281b
Compare
|
(the reason snyk reports in red even though I changed none of the dependencies it's complaining about is exactly what I'm trying to fix) |
|
It's part of what we're investigating so let's try it. We can revert if it something unexpected happens ⚡ |
mnowster
approved these changes
Feb 23, 2022
JamWils
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #1503
What changed?
This upgrades the version of go-checkpoint. The new version has absolutely no code changes.
Yes, this clear-the-way PR is against main. It's supposed to be against main. Snyk's github integration only works against the default branch.
Why?
This is a bit of a stab in the dark to try to get the snyk github
integration working (part of #1503) - apparently we can't have
dependencies without go.mod files?
How did you test it?
There are checkpoint tests already, and this changes literally no code. I did try dumping the response from checkpoint to see that it's still returning "sensible" values.