Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pull the gomega deps #373

Merged
merged 6 commits into from Jun 23, 2021
Merged

pull the gomega deps #373

merged 6 commits into from Jun 23, 2021

Conversation

iahmad9
Copy link
Contributor

@iahmad9 iahmad9 commented Jun 22, 2021

What changed?
Pull go mega module before running acceptance tests in deploy job.

Why?
Deploy job is broken since PR#309 is merged

bigkevmcd
bigkevmcd reviewed Jun 22, 2021
View reviewed changes
Copy link
Contributor

@bigkevmcd bigkevmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I suggest using the tools.go pattern to help with versioning the tools?

@iahmad9
Copy link
Contributor Author

iahmad9 commented Jun 23, 2021

Can I suggest using the tools.go pattern to help with versioning the tools?

@bigkevmcd thanks for your review, it's a good idea. I'll look into it and see if that can be done across the jobs in separate PR.

@iahmad9 iahmad9 requested a review from saeedfazal June 23, 2021 10:38
@iahmad9 iahmad9 merged commit f597d1d into main Jun 23, 2021
@iahmad9 iahmad9 deleted the fix-deploy-job branch July 1, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigkevmcd bigkevmcd bigkevmcd left review comments

@saeedfazal saeedfazal saeedfazal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iahmad9 @bigkevmcd @saeedfazal