Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Fix attach-bridge bugs #1964

Merged
merged 3 commits into from
Feb 9, 2016
Merged

Fix attach-bridge bugs #1964

merged 3 commits into from
Feb 9, 2016

Conversation

awh
Copy link
Contributor

@awh awh commented Feb 9, 2016

#1955 introduced three bugs:

  • weave reset did not clean up veth pairs created by weave attach-bridge
  • weave reset did not clean up iptables rules inserted by weave attach-bridge
  • weave attach-bridge was not idempotent in terms of iptables rules creation

@awh awh added this to the 1.5.0 milestone Feb 9, 2016
@awh awh changed the title Remove all vethwe* interfaces in reset Fix attach-bridge bugs Feb 9, 2016
@awh
Copy link
Contributor Author

awh commented Feb 9, 2016

Is it worth adding an insert_iptables_rule helper?

@rade
Copy link
Member

rade commented Feb 9, 2016

Is it worth adding an insert_iptables_rule helper?

Done.

@rade rade self-assigned this Feb 9, 2016
rade added a commit that referenced this pull request Feb 9, 2016
@rade
Merge pull request #1964 from weaveworks/weave-veth-cleanup
5707581 
Fix attach-bridge bugs
@rade rade merged commit 5707581 into master Feb 9, 2016
@rade rade deleted the weave-veth-cleanup branch February 9, 2016 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@rade rade

Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@awh @rade