This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Proxy shouldn't weave-attach containers which are using a network plugin #2330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly intended for cases where the user has configured the proxy and also said --net=weave, but will catch any other plugin similarly
bboreham
force-pushed
the
issues/1988-proxy-plugin
branch
from
9d35198
to
dac2124
Compare
rade
added a commit
that referenced
this pull request
Jul 20, 2016
since as of #2330 the proxy ignores containers started with specified user networks.
awh
pushed a commit
that referenced
this pull request
Jul 28, 2016
since as of #2330 the proxy ignores containers started with specified user networks.
brb
pushed a commit
that referenced
this pull request
Aug 1, 2016
since as of #2330 the proxy ignores containers started with specified user networks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1988 per the last sentence in the description:
"unset" equates to
default, as far as I can see.Note this would be a breaking change for someone who is deliberately using the Weave proxy together with another plugin. Those folks (if they exist) can
docker network connect foo, I guess.(note that
docker run --net a --net b ...only connects to networkb)