This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle problem with copying a map by reference, so the copy actually changed the data in the original so it looked like the operation succeeded.
This problem was masking another problem, that the keys used for annotations to mark a peer as 'currently being removed' contained
:
characters which are not allowed by Kubernetes.The big improvement is to use the updated data that comes back from
Update()
, even after an error.Fixes #3190
I have tested this by creating a 10-node cluster using kops, then scaling down to 5 nodes, then scaling back up to 10 nodes, finally using the
nettest
image to check that 30 pods can all talk to each other.