This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Fix ipam reclaim #3192
Merged
Fix ipam reclaim #3192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rade
reviewed
Dec 1, 2017
prog/kube-peers/annotations.go
Outdated
| if err == nil { | ||
| cml.cm = cm | ||
| } | ||
| cml.cm = cm |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
bboreham
force-pushed
the
issues/3190-deepcopy-configmaps
branch
from
444f13a
to
47aba94
Compare
e.g. if we get a clash because someone else has updated the data, it returns the new data so we should work off that next time. Also re-fetch the Annotations every time round the main loop for safety.
E.g. replace "26:c6:0b:ba:fd:31" with "26_c6_0b_ba_fd_31"
bboreham
force-pushed
the
issues/3190-deepcopy-configmaps
branch
from
47aba94
to
d2ed91c
Compare
rade
approved these changes
Dec 1, 2017
This was referenced Dec 4, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a subtle problem with copying a map by reference, so the copy actually changed the data in the original so it looked like the operation succeeded.
This problem was masking another problem, that the keys used for annotations to mark a peer as 'currently being removed' contained
:characters which are not allowed by Kubernetes.The big improvement is to use the updated data that comes back from
Update(), even after an error.Fixes #3190
I have tested this by creating a 10-node cluster using kops, then scaling down to 5 nodes, then scaling back up to 10 nodes, finally using the
nettestimage to check that 30 pods can all talk to each other.