This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Document weave log warning and error levels #3594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 6, 2019
|
LGTM. Failed smoke test is flaky test failure. |
|
Thanks for the review. Since this is my first PR here, I'd just like to be clear. Am I good to merge now, or is there some other protocol I need to follow? |
|
@jrryjcksn can you please rebase against And the protocol in this project is 'reviewer merges' |
jrryjcksn
force-pushed
the
document_weave_log_warning_and_error_levels
branch
from
2ada04b
to
8a5aa1a
Compare
|
Rebased to 2.5. Thanks for the info! |
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only
infoanddebuglog levels were mentioned in the documentation.Fixes #2834