Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Commit

Permalink
Remove redundant instructions/comments for local-docker-registry
Browse files Browse the repository at this point in the history
  • Loading branch information
fbarl committed Sep 26, 2019
1 parent b0d166e commit 228aa95
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 18 deletions.
9 changes: 0 additions & 9 deletions environments/local-docker-registry/README.md
Expand Up @@ -23,12 +23,3 @@ just to speed up integration tests, among other scenarii.
```console
./retag_push.sh
```

## Future work

Ideally, the `retag_push.sh` script should be automatically generated by WKS
based on the current cluster configuration, e.g. Kubernetes version used in the
machines manifest, `imageRepository` used in the cluster manifest, etc.
WKS v1, which was based on Pharos, had a "retag" feature to do the equivalent
of this script with Pharos' images and their dependencies.
We should implement something similar for WKS v2.
10 changes: 1 addition & 9 deletions environments/local-docker-registry/retag_push.sh
Expand Up @@ -9,16 +9,8 @@
# of Kubernetes WKS runs. You can retrieve these by running:
# kubeadm config images list
# (see also https://kubernetes.io/docs/reference/setup-tools/kubeadm/kubeadm-config/#cmd-config-images-list)
# on the WKS seed master node, or by looking at either wk or the WKS
# on the WKS seed master node, or by looking at the WKS
# controller's logs.
#
# Future work:
# Ideally, this script should be automatically generated by WKS based on the
# current cluster configuration, e.g. Kubernetes version used in the machines
# manifest, imageRepository used in the cluster manifest, etc.
# WKS v1, which was based on Pharos, had a "retag" feature to do the
# equivalent of the below with Pharos' images and their dependencies.
# We should implement something similar for WKS v2.

set -e

Expand Down

0 comments on commit 228aa95

Please sign in to comment.