This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
ensure initial master has associated plan so it will not be re-provisioned #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the review! |
jrryjcksn
deleted the
2020-1-15-fix-for-ignite-firekube-cluster-creation-bug
branch
D3nn
pushed a commit
that referenced
this pull request
May 8, 2020
…ioned (#118) Co-authored-by: weave-e2e-quickstart <58864910+weave-e2e-quickstart@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible for an
updateto come in for the initial master before the first other node is created by the controller. If this happens, the initial master has not yet had aplanassigned so the controller updates it (the controller compares old and new plans to determine if a node must be updated). This PR ensures that the initial master has a plan before allowing any updates to occur.