This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
allow specification of initial kubelet version in machines file #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarl
approved these changes
Jan 21, 2020
There was a problem hiding this comment.
Thanks for the PR, good catch! 👍
Before you merge, could you please add a simple test to machine_test.go that verifies it's ok to have a kubelet version specified without the control plane version?
foot
approved these changes
Jan 22, 2020
jrryjcksn
deleted the
allow-specification-of-initial-kubelet-version-in-machines-file
branch
D3nn
pushed a commit
that referenced
this pull request
May 8, 2020
* allow specification of initial kubelet version in machines file * Add test for allowing specification of kubelet version without controlPlane version Co-authored-by: weave-e2e-quickstart <58864910+weave-e2e-quickstart@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA - loosens validation of machines manifest to allow specification of only kubelet version.