Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

allow specifying version with --controller-version or --dependency-file #129

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

jrryjcksn
Copy link
Contributor

Since wksctl can be used without a dependency file, maintain the --controller-version option while adding the --dependency-file option. The dependency file will take precedence.

@jrryjcksn jrryjcksn self-assigned this Feb 4, 2020
cmd/wksctl/init/init.go Outdated Show resolved Hide resolved
@jrryjcksn jrryjcksn merged commit 684a8fb into master Feb 5, 2020
@jrryjcksn jrryjcksn deleted the maintain-dependencies-as-toml-file branch February 5, 2020 20:58
@kingdonb
Copy link

kingdonb commented Feb 27, 2020

I am using firekube and just bumped my wksctl to alpha4, which fails at:

log "Updating container images and git parameters"
wksctl init --git-url="$(git_ssh_url "$(git_remote_fetchurl "${git_remote}")")" --git-branch="$(git_current_branch)"

from setup.sh, with this error:

• Updating container images and git parameters
open ./dependencies.toml: no such file or directory

It looks like this is meant to be an optional argument, to phase in dependencies.toml. I was able to bypass it by touching an empty dependencies.toml, I'm not sure if that's intentional or if I should need to do that.

Maybe you have already planned to update firekube with a dependencies.toml before the next wksctl release, I just noticed it's been a bit since this was merged, and it doesn't look like there is any documentation / example or note about what kind of dependencies that file is for exactly.

D3nn pushed a commit that referenced this pull request May 8, 2020
…le (#129)

* allow specifying version with --controller-version or --dependency-file

* switch to full file name "dependencies.toml"

* Fix unit tests

* cleanup based on review comments

Co-authored-by: weave-e2e-quickstart <58864910+weave-e2e-quickstart@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants