This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Attempt to fix build failure in forked PRs #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palemtnrider
approved these changes
Mar 26, 2020
jrryjcksn
force-pushed
the
attempt-to-fix-build-failure-in-forked-PRs
branch
from
63ae4bc
to
7c6743b
Compare
Merged
D3nn
pushed a commit
that referenced
this pull request
May 8, 2020
* only push image if quay.io credentials are present * fix command to be multi-line string * flip backward test * Add comment so circle will see the previous change * only run gcp integration tests if secret key is available * fix typo in config file * Update rhel test to check for secret_key Co-authored-by: Jerry Jackson <jerry@weave.works> Co-authored-by: Mark Emeis <mark.emeis@weave.works>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests from external forks fail to build due to lack of quay.io credentials. This PR changes the CircleCI configuration to only push if credentials are available.