This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Install Sealed Secrets CRD before controller #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dinos Kousidis <dinos@weave.works>
dinosk
force-pushed
the
fix-sealed-secrets-installation-order
branch
from
2ee64a0
to
6490948
Compare
saada
reviewed
Mar 30, 2020
| b.AddResource("install:sealed-secrets-key", &resource.KubectlApply{Manifest: manifest}) | ||
| file, err := manifests.Manifests.Open("05_sealed_secret_controller.yaml") | ||
| file, err := manifests.Manifests.Open("06_sealed_secret_controller.yaml") |
There was a problem hiding this comment.
I'm curious why we needed to update the file name from 05 to 06
There was a problem hiding this comment.
I just added the CRD as 05 and thought to increase the controller
D3nn
pushed a commit
that referenced
this pull request
May 8, 2020
…on-order Install Sealed Secrets CRD before controller
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dinos Kousidis dinos@weave.works