[WKP-468] test for debug log level #173

D3nn · 2020-04-28T22:52:56Z

wksctl with --verbose flag should set log level to debug on wks-controller
test should check logs to ensure debug level messages are output from kubectl logs wks-controller

palemtnrider · 2020-04-30T23:22:32Z

I don't see in your test code where you set the logging level to verbose? I only see you looking for a log message saying it's in debug mode.

D3nn · 2020-05-01T14:18:28Z

I don't see in your test code where you set the logging level to verbose? I only see you looking for a log message saying it's in debug mode.

In TestApply, you should find this:

	// Install the Cluster.
	run, err := apply(exe, "--cluster="+clusterManifestPath, "--machines="+machinesManifestPath, "--namespace=default",
		"--config-directory="+configDir, "--sealed-secret-key="+configPath("ss.key"), "--sealed-secret-cert="+configPath("ss.cert"),
		"--verbose=true", "--ssh-key="+sshKeyPath)
	assert.NoError(t, err)
	assert.Equal(t, 0, run.ExitCode())
...

jrryjcksn

LGTM \o/

palemtnrider

I like that we are now checking both verbose and not.

… created

* test for debug log level * make verbose setting configurable in test * test for debug log level * make verbose setting configurable in test * updates to verbose logging testcase * test for debug log level * make verbose setting configurable in test * test for debug log level * make verbose setting configurable in test * updates to verbose logging testcase * check verbose from json output * add logging debug statement * fixes for TestApply * print run object in test for debugging * Old version of kubectl doesn't support -A * test fixes to work with outdated kubectl * Wait for all output to complete in test executor * select specific output from kubectl command looking for "--verbose" * switch to standard exec.Cmd * small fix * fix missing imports that "make lint" did not catch * debug logging for pods * debug * debug * switch to default namespace in test because that's how the cluster is created Co-authored-by: Mark Emeis <mark.emeis@weave.works> Co-authored-by: Jerry Jackson <jerry@weave.works>

D3nn force-pushed the WKP-468-verify-log-level branch 2 times, most recently from 2bda482 to ac1c23d Compare April 28, 2020 23:27

D3nn self-assigned this Apr 29, 2020

D3nn requested review from palemtnrider and dinosk April 29, 2020 15:42

D3nn marked this pull request as ready for review April 29, 2020 15:42

test for debug log level

0138fbc

D3nn force-pushed the WKP-468-verify-log-level branch from ac1c23d to 0138fbc Compare April 29, 2020 15:44

D3nn added 4 commits May 5, 2020 06:44

make verbose setting configurable in test

3b06d1b

test for debug log level

a082e47

make verbose setting configurable in test

abd138d

Merge remote into local branch

8d61f43

D3nn force-pushed the WKP-468-verify-log-level branch from 64b57e9 to e797a03 Compare May 5, 2020 16:16

jrryjcksn approved these changes May 5, 2020

View reviewed changes

D3nn force-pushed the WKP-468-verify-log-level branch from e797a03 to 4c49f09 Compare May 5, 2020 16:31

updates to verbose logging testcase

9ce4112

D3nn force-pushed the WKP-468-verify-log-level branch from 4c49f09 to 9ce4112 Compare May 5, 2020 16:43

palemtnrider approved these changes May 5, 2020

View reviewed changes

D3nn added 8 commits May 5, 2020 17:05

test for debug log level

3e1e7ed

make verbose setting configurable in test

1e1cb82

test for debug log level

5be9311

make verbose setting configurable in test

5898712

updates to verbose logging testcase

58254d6

apply test checks for verbose setting

53f69b0

check verbose from json output

7540e9d

add logging debug statement

490b70e

D3nn changed the title ~~test for debug log level~~ [WKP-468] test for debug log level May 6, 2020

fixes for TestApply

c803fee

D3nn force-pushed the WKP-468-verify-log-level branch from 44100b5 to c803fee Compare May 7, 2020 01:05

D3nn and others added 3 commits May 6, 2020 19:41

print run object in test for debugging

9a79860

Old version of kubectl doesn't support -A

1f33ef6

test fixes to work with outdated kubectl

8919b49

D3nn force-pushed the WKP-468-verify-log-level branch from dc57614 to 8919b49 Compare May 7, 2020 17:28

weave-e2e-quickstart added 9 commits May 7, 2020 12:29

Wait for all output to complete in test executor

731439d

select specific output from kubectl command looking for "--verbose"

5e58184

switch to standard exec.Cmd

5d53496

small fix

aaaced1

fix missing imports that "make lint" did not catch

0dcc4aa

debug logging for pods

3f5d669

debug

7c9bade

debug

63743d6

switch to default namespace in test because that's how the cluster is…

10f981e

… created

D3nn merged commit 84a21a1 into master May 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WKP-468] test for debug log level #173

[WKP-468] test for debug log level #173

D3nn commented Apr 28, 2020

palemtnrider commented Apr 30, 2020

D3nn commented May 1, 2020 •

edited

Loading

jrryjcksn left a comment

palemtnrider left a comment

[WKP-468] test for debug log level #173

[WKP-468] test for debug log level #173

Conversation

D3nn commented Apr 28, 2020

palemtnrider commented Apr 30, 2020

D3nn commented May 1, 2020 • edited Loading

jrryjcksn left a comment

Choose a reason for hiding this comment

palemtnrider left a comment

Choose a reason for hiding this comment

D3nn commented May 1, 2020 •

edited

Loading