Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

v1alpha3 - Rename BareMetal to ExistingInfra #224

Merged
merged 5 commits into from Jul 29, 2020
Merged

v1alpha3 - Rename BareMetal to ExistingInfra #224

merged 5 commits into from Jul 29, 2020
+593 −528

Conversation

bboreham
Copy link
Contributor

"BareMetal" may make people think we are pxe-booting, while the point of this provider is to take existing machines that run Linux and bring up a Kubernetes node on them.

"ExistingInfra" was one name proposed, so I made this PR to see how it looked.

@bboreham bboreham mentioned this pull request Jun 18, 2020
Closed
@yiannistri
Copy link
Contributor

In my opinion, "ExistingInfra" is more precise a term than "BYOB".

@bboreham bboreham closed this Jun 24, 2020
@bboreham bboreham reopened this Jun 24, 2020
Base automatically changed from update-to-v1alpha3 to master June 24, 2020 16:21
@luxas
Copy link
Contributor

luxas commented Jul 9, 2020

I prefer this one over the other. Couldn't understand what BYOB was in the first ten seconds I looked at it

@bboreham @twelho
Rename 'BareMetal' to 'ExistingInfra'
dc35e6f 
Also standardise the import name 'existinginfrav1'
@bboreham @twelho
Update vfsdata files
8dfd8da 
Signed-off-by: Dennis Marttinen <dennis@weave.works>
@twelho
Rename variable name references from BareMetal* to ExistingInfra*
48491db 
Signed-off-by: Dennis Marttinen <dennis@weave.works>
@D3nn
Copy link
Contributor

D3nn commented Jul 27, 2020

In my opinion, "ExistingInfra" is more precise a term than "BYOB".

I don't know about it in Europe, but BYOB in the US generally means "Bring Your Own Beer." Somehow I don't think that's what @yiannistri has in mind.

@bboreham
Copy link
Contributor Author

bboreham commented Jul 27, 2020 •
edited

CI failed; looks like flake #241
Passed on re-run.

@twelho
Update examples to ExistingInfra* using crdconv
f426bd3 
Signed-off-by: Dennis Marttinen <dennis@weave.works>
@twelho
Statically define machine names the Vagrant example (crdconv update)
43fa083 
Signed-off-by: Dennis Marttinen <dennis@weave.works>
@twelho
Copy link
Contributor

twelho commented Jul 29, 2020 •
edited

@bboreham there's one remaining use of v1alpha1 BareMetal* in the examples in the generate-machines-manifest.js script, should I refactor it to v1alpha3 ExistingInfra* as well? I don't have a way to test the GCE examples by hand. Are these used/covered by CI?

@bboreham
Copy link
Contributor Author

Thanks for doing the examples, @twelho. Yes it is best to make everything consistent but I was ok to do it later.

I don't believe any of them are covered by CI.

@luxas luxas merged commit 4125b77 into master Jul 29, 2020
@twelho twelho deleted the existinginfra branch July 31, 2020 11:14
@twelho twelho mentioned this pull request Jul 31, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luxas luxas luxas approved these changes

@yiannistri yiannistri yiannistri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bboreham @yiannistri @luxas @D3nn @twelho