Skip to content
This repository has been archived by the owner on Mar 31, 2023. It is now read-only.

Ensure tests are running with debug #304

Merged
merged 5 commits into from Sep 10, 2020
Merged

Conversation

D3nn
Copy link
Contributor

@D3nn D3nn commented Sep 8, 2020

No description provided.

Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Makefile Outdated
@@ -139,6 +139,7 @@ integration-tests-container: cmd/wksctl/wksctl
NODE_OS2="ubuntu"
NODE_OS_CHOICE=$${NODE_OS_CHOICE:-"$$(echo $$NODE_OS1 $$NODE_OS2 | tr ' ' '\n' | shuf | head -1)"}
IMAGE_TAG=$(IMAGE_TAG) NODE_OS="$${NODE_OS_CHOICE}" go test -v -timeout 40m ./test/integration/container/...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be removed!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@D3nn D3nn changed the title fix erroneous image name and machines filename Ensure tests are running with debug Sep 9, 2020
Copy link
Contributor

@palemtnrider palemtnrider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palemtnrider palemtnrider merged commit 69d2203 into master Sep 10, 2020
@palemtnrider palemtnrider deleted the fix_unhelpful_error_message branch September 10, 2020 19:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants