This repository has been archived by the owner on Mar 31, 2023. It is now read-only.
Annotate seed node via file #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can contain shell characters such as single quote and !, so put the contents in a file before calling `kubectl annotate`. Interestingly there is no option in `kubectl` to take the value from a file, so we still have to `cat` it on the command-line.
bboreham
force-pushed
the
annotate-via-file
branch
from
686821f
to
2296a7b
Compare
palemtnrider
approved these changes
Oct 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We put the node plan on each node as an annotation.
The plan value can contain shell characters such as
'and!, so put the contents in a file before callingkubectl annotate.Interestingly there is no option in
kubectlto take the value from a file, so we still have tocatit on the command-line.This change is based on http://github.com/weaveworks/cluster-api-provider-existinginfra/pull/30, since I noticed
WriteFile()was in a strange place.