-
Notifications
You must be signed in to change notification settings - Fork 55
Get dynamic latest CAPEI release #331
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The update to multimaster_test looks good; I think we need to change the controller manifest, though...
@@ -42,7 +42,7 @@ spec: | |||
operator: Exists | |||
containers: | |||
- name: controller | |||
image: weaveworks/cluster-api-existinginfra-controller:v0.2.4 | |||
image: weaveworks/cluster-api-existinginfra-controller:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it's safe to use latest
here. That would mean that any wk
binary someone used after CAPEI got updated would end up pulling the new manifest (which could easily be inconsistent w/ the binary in some way) 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jrryjcksn You're right. I'll revert this.
@@ -376,8 +404,10 @@ func TestMultimasterSetup(t *testing.T) { | |||
if shouldRetagPush(t, registryPort) { | |||
run(t, filepath.Join(rootDir, "environments/local-docker-registry/retag_push.sh"), "-p", strconv.Itoa(registryPort)) | |||
} | |||
// FIXME: look this value up more dynamically. | |||
const capeiImage = "weaveworks/cluster-api-existinginfra-controller:v0.2.4" | |||
release, err := getLatestCAPEIRelease() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, though, it seems great! :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we want the version that matches the go.mod file - otherwise there is the potential to create the seed node with one version and the remaining nodes with a different version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems interesting. I'm curious in how that could happen. Would getLatestCAPEIRelease()
be called many times? It seems just to be called once. 🙂
No description provided.