Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GET /c11/words does not reflect occurence #947

Closed
bobvanluijt opened this issue Aug 9, 2019 · 8 comments
Closed

GET /c11/words does not reflect occurence #947

bobvanluijt opened this issue Aug 9, 2019 · 8 comments
Assignees
Labels

Comments

@bobvanluijt
Copy link
Member

Let's take the following end-point; /c11y/words/movieActor.

It seems like the concatenated centroid is using the "old" way of concatenating and not using the word occurrences like the algo that is used to calculate the centroid of a new thing or action.

@etiennedi
Copy link
Member

etiennedi commented Aug 9, 2019

The occurrence feature was added in contextionary version enX.X.X-v0.3.0. Which version are you using, maybe you're just using an older one than that?

@bobvanluijt
Copy link
Member Author

Aha, so just to make sure, the functionality used in these endpoints comes 100% from the C11y-service. It couldn't be the case that we have some old calculation legacy?

@etiennedi
Copy link
Member

Hm, good point. There might acutally be some leftovers in the handler itself, which means they might not make use of the new centroid building.

When we build the centroids in explore: { concepts: [ ] } for example, I know for a fact that it's used.

I'll investigate about the endpoint.

@bobvanluijt
Copy link
Member Author

I'll investigate about the endpoint

I would appreciate that.

@etiennedi
Copy link
Member

etiennedi commented Aug 9, 2019

You are indeed correct, the /c11y/ enpoint has some legacy code (there's even a big TODO at the top mentioning that this logic should be removed from the handler) and it does not do any occurence based weighing. I'm adding the bug label to this issue and renaming the title to fix it.

@etiennedi etiennedi added the bug label Aug 9, 2019
@etiennedi etiennedi changed the title Question: is the c11y concatenation using the occurrence? GET /c11/words does not reflect occurence Aug 9, 2019
@bobvanluijt
Copy link
Member Author

Aha, fantastic, good to know.

@fefi42 please note a dependency for your classification work on this one.

@etiennedi
Copy link
Member

I'll prioritize this accordingly, but it'll probably be next week, before we have a fix on this.

@bobvanluijt
Copy link
Member Author

Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants