Fix create/update timestamp issues in GraphQL and REST #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkerduckworth
force-pushed
the
bugfix/gql-timestamps
branch
from
81a1ccd
to
5850cda
Compare
Codecov Report
@@ Coverage Diff @@
## master #1847 +/- ##
==========================================
+ Coverage 65.98% 66.06% +0.08%
==========================================
Files 411 411
Lines 30895 30915 +20
==========================================
+ Hits 20386 20425 +39
+ Misses 8716 8691 -25
- Partials 1793 1799 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
etiennedi
reviewed
Mar 9, 2022
| // otherwise it is lost. This is because `class` is unmarshaled | ||
| // directly from the request body, therefore `CreationTimeUnix` | ||
| // inherits the zero value. | ||
| class.CreationTimeUnix = originalObject.Created |
There was a problem hiding this comment.
Love this comment. The perfect level of information about why we do this.
|
Just pushed some some tests to |
antas-marcin
approved these changes
Mar 9, 2022
|
Documentation will need to be updated on the GraphQL Additional Properties reference page |
parkerduckworth
force-pushed
the
bugfix/gql-timestamps
branch
from
09a7f17
to
01a8262
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Set the original creation timestamp before call to put, otherwise it is lost. This is because
classis unmarshaled directly from the request body, thereforeCreationTimeUnixinherits the zero value.Add
creationTimeUnixandlastUpdateTimeUnixfields toGetgraphql query asString'sWrite tests to assert both
1.and2.Fixes #1844