Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/periodically scan disk #1861

Merged
merged 27 commits into from Mar 22, 2022
Merged

Conversation

parkerduckworth
Copy link
Member

@parkerduckworth parkerduckworth commented Mar 16, 2022

Changes

Introduce 2 new configuration variables:

DISK_USE_WARNING_PERCENTAGE:
  • Sets disk use threshold for triggering log warnings
DISK_USE_READONLY_PERCENTAGE:
  • Sets disk use threshold for triggering shard status set to READONLY

@parkerduckworth parkerduckworth changed the base branch from gh-1839-read-only-shards to master March 17, 2022 11:39
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #1861 (d9168a3) into master (7860f17) will decrease coverage by 0.02%.
The diff coverage is 53.59%.

❗ Current head d9168a3 differs from pull request most recent head 9af573a. Consider uploading reports for the commit 9af573a to get more accurate results

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   66.27%   66.24%   -0.03%     
==========================================
  Files         415      417       +2     
  Lines       31433    31573     +140     
==========================================
+ Hits        20833    20917      +84     
- Misses       8792     8837      +45     
- Partials     1808     1819      +11     
Flag Coverage Δ
integration 67.18% <65.07%> (+0.04%) ⬆️
unittests 66.24% <53.59%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/handlers/rest/configure_api.go 0.00% <0.00%> (ø)
...dapters/repos/db/lsmkv/segment_group_compaction.go 68.21% <ø> (-0.96%) ⬇️
usecases/config/config_handler.go 0.00% <0.00%> (ø)
usecases/config/environment.go 0.00% <0.00%> (ø)
adapters/repos/db/shard_disk_use.go 25.53% <25.53%> (ø)
adapters/repos/db/disk_use.go 81.08% <81.08%> (ø)
adapters/repos/db/repo.go 80.00% <84.61%> (+1.05%) ⬆️
adapters/repos/db/index.go 69.34% <100.00%> (+0.19%) ⬆️
adapters/repos/db/init.go 59.25% <100.00%> (+3.25%) ⬆️
adapters/repos/db/lsmkv/store.go 70.73% <100.00%> (+3.16%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38293e2...9af573a. Read the comment docs.

@parkerduckworth parkerduckworth merged commit 68c170f into master Mar 22, 2022
@parkerduckworth parkerduckworth deleted the feature/periodically-scan-disk branch March 22, 2022 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants