Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tag regex pattern update #1869

Merged
merged 2 commits into from Mar 22, 2022
Merged

Build tag regex pattern update #1869

merged 2 commits into from Mar 22, 2022

Conversation

parkerduckworth
Copy link
Member

Updated the license header addition script to look for //go:build, the conditional compilation directive added in go1.17, so that build tags are not overwritten in the process. Also small typo fix in a disk use debug log.

@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #1869 (b3aa81a) into master (7860f17) will decrease coverage by 0.04%.
The diff coverage is 53.59%.

@@            Coverage Diff             @@
##           master    #1869      +/-   ##
==========================================
- Coverage   66.27%   66.23%   -0.05%     
==========================================
  Files         415      417       +2     
  Lines       31433    31573     +140     
==========================================
+ Hits        20833    20911      +78     
- Misses       8792     8846      +54     
- Partials     1808     1816       +8     
Flag Coverage Δ
integration 67.12% <65.07%> (-0.02%) ⬇️
unittests 66.23% <53.59%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/handlers/rest/configure_api.go 0.00% <0.00%> (ø)
...dapters/repos/db/lsmkv/segment_group_compaction.go 68.21% <ø> (-0.96%) ⬇️
usecases/config/config_handler.go 0.00% <0.00%> (ø)
usecases/config/environment.go 0.00% <0.00%> (ø)
adapters/repos/db/shard_disk_use.go 25.53% <25.53%> (ø)
adapters/repos/db/disk_use.go 81.08% <81.08%> (ø)
adapters/repos/db/repo.go 80.00% <84.61%> (+1.05%) ⬆️
adapters/repos/db/index.go 69.34% <100.00%> (+0.19%) ⬆️
adapters/repos/db/init.go 59.25% <100.00%> (+3.25%) ⬆️
adapters/repos/db/lsmkv/store.go 70.73% <100.00%> (+3.16%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfde2d2...b3aa81a. Read the comment docs.

@parkerduckworth parkerduckworth merged commit 25fb25e into master Mar 22, 2022
@parkerduckworth parkerduckworth deleted the bugfix/WEAVIATE-59 branch March 22, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant