Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SEGFAULT error after compaction #2349

Merged
merged 2 commits into from
Nov 15, 2022
Merged

Fixes SEGFAULT error after compaction #2349

merged 2 commits into from
Nov 15, 2022

Conversation

aliszka
Copy link
Member

@aliszka aliszka commented Nov 10, 2022

What's being changed:

Added missing lock releases on error occurrences
Object's slice is copied after being read from bucket (replace strategy; already implemented for lists and maps)

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Base: 68.06% // Head: 68.03% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (d490ed3) compared to base (a36eec1).
Patch coverage: 71.87% of modified lines in pull request are covered.

❗ Current head d490ed3 differs from pull request most recent head 3f189e1. Consider uploading reports for the commit 3f189e1 to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           stable/v1.16    #2349      +/-   ##
================================================
- Coverage         68.06%   68.03%   -0.04%     
================================================
  Files               530      530              
  Lines             53321    53339      +18     
================================================
- Hits              36292    36287       -5     
- Misses            14795    14816      +21     
- Partials           2234     2236       +2     
Flag Coverage Δ
integration 68.67% <70.00%> (-0.10%) ⬇️
unittests 53.32% <12.50%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
adapters/repos/db/shard_write_put.go 53.24% <42.85%> (-0.79%) ⬇️
adapters/repos/db/shard_write_merge.go 48.57% <58.33%> (-2.17%) ⬇️
adapters/handlers/rest/embedded_spec.go 100.00% <100.00%> (ø)
...dapters/repos/db/lsmkv/segment_replace_strategy.go 63.85% <100.00%> (+3.32%) ⬆️
adapters/repos/db/lsmkv/segment_serialization.go 62.04% <100.00%> (+0.14%) ⬆️
adapters/repos/db/vector/hnsw/delete.go 76.20% <0.00%> (-1.69%) ⬇️
...pters/repos/db/vector/hnsw/neighbor_connections.go 66.82% <0.00%> (-1.43%) ⬇️
adapters/repos/db/lsmkv/bucket.go 65.90% <0.00%> (-0.92%) ⬇️
adapters/repos/db/vector/hnsw/index.go 57.57% <0.00%> (-0.87%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aliszka aliszka force-pushed the fix/WVT-368 branch 2 times, most recently from 53b95da to 5a08dd5 Compare November 11, 2022 13:49
@aliszka aliszka changed the base branch from master to stable/v1.16 November 11, 2022 14:44
@aliszka aliszka force-pushed the fix/WVT-368 branch 2 times, most recently from 5a08dd5 to 02ba3b2 Compare November 15, 2022 11:26
@aliszka aliszka marked this pull request as ready for review November 15, 2022 11:27
@etiennedi etiennedi merged commit ca13ddd into stable/v1.16 Nov 15, 2022
@etiennedi etiennedi deleted the fix/WVT-368 branch November 15, 2022 14:23
trengrj pushed a commit to trengrj/weaviate that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants