Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HNSW+BQ #3841

Merged
merged 35 commits into from
Dec 22, 2023
Merged

HNSW+BQ #3841

merged 35 commits into from
Dec 22, 2023

Conversation

abdelr
Copy link
Contributor

@abdelr abdelr commented Dec 1, 2023 •
edited

What's being changed:

Introducing HNSW+BQ. This PR introduces a generic implementation of compression that relies either on PQ or BQ. Currently, we only support these compression methods but if in the future we need something else, it should also work.

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@abdelr abdelr self-assigned this Dec 1, 2023
@abdelr
Copy link
Contributor Author

abdelr commented Dec 1, 2023

Please, start taking a look but keep in mind that restoring the index is not supported yet. I will work on it next week.

@abdelr abdelr marked this pull request as draft December 1, 2023 13:59
@abdelr abdelr requested a review from etiennedi December 1, 2023 13:59
@abdelr abdelr changed the title Only missing restoring the index HNSW+BQ Dec 2, 2023
@abdelr abdelr marked this pull request as ready for review December 4, 2023 21:55
aliszka
aliszka reviewed Dec 6, 2023
View reviewed changes
adapters/repos/db/vector/hnsw/compress.go Outdated Show resolved Hide resolved
adapters/repos/db/vector/hnsw/backup.go Outdated Show resolved Hide resolved
adapters/repos/db/vector/hnsw/backup.go Outdated Show resolved Hide resolved
@trengrj trengrj linked an issue Dec 14, 2023 that may be closed by this pull request
Binary Quantization for HNSW #3901
Closed
aliszka
aliszka reviewed Dec 20, 2023
View reviewed changes
adapters/repos/db/vector/hnsw/compress.go Show resolved Hide resolved
adapters/repos/db/vector/hnsw/deserializer.go Outdated Show resolved Hide resolved
adapters/repos/db/vector/hnsw/backup.go Outdated Show resolved Hide resolved
adapters/repos/db/vector/hnsw/backup.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

24 New issues
0 Security Hotspots
No data about Coverage
1.7% Duplication on New Code

See analysis details on SonarCloud

@abdelr abdelr merged commit b10d399 into master Dec 22, 2023
23 checks passed
@abdelr abdelr deleted the HNSW_BQ branch December 22, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aliszka aliszka aliszka approved these changes

@asdine asdine Awaiting requested review from asdine

@trengrj trengrj Awaiting requested review from trengrj

@CShorten CShorten Awaiting requested review from CShorten

@parkerduckworth parkerduckworth Awaiting requested review from parkerduckworth

@etiennedi etiennedi Awaiting requested review from etiennedi

Assignees

@abdelr abdelr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Binary Quantization for HNSW
2 participants
@abdelr @aliszka