Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAFT: Replace slog with logrus for logs consistency #4753

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented Apr 24, 2024

What's being changed:

combined effort with @trengrj

  • replaces all slog usage with logrus
  • implements the hclog.Logger interface as a a wrapper for logrus to be used in RAFT as required for the config logger

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, requested change on the switch I think we should cover all cases. Let me know if you disagree and we can talk about it and ignore it in the linter if we feel this is the right move to make.

adapters/handlers/rest/configure_api.go Outdated Show resolved Hide resolved
cluster/store/logger.go Show resolved Hide resolved
cluster/store/logger.go Show resolved Hide resolved
@moogacs
Copy link
Contributor Author

moogacs commented Apr 24, 2024

ageed in all points, just missed the linter

@moogacs moogacs requested a review from reyreaud-l April 24, 2024 09:32
Copy link

sonarcloud bot commented Apr 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

cluster/store/logger.go Show resolved Hide resolved
@moogacs moogacs merged commit d03e1b3 into main Apr 24, 2024
40 of 41 checks passed
@moogacs moogacs deleted the trengrj/logrus-raft branch April 24, 2024 09:57
@nathanwilk7 nathanwilk7 mentioned this pull request Apr 24, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants