errgroup wait correction on idx add property #4768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moogacs
force-pushed
the
correct-idx-add-concurrency-properties
branch
from
25e2183
to
b5c1e05
Compare
moogacs
force-pushed
the
correct-idx-add-concurrency-properties
branch
from
b5c1e05
to
b246329
Compare
moogacs
force-pushed
the
correct-idx-add-concurrency-properties
branch
from
b246329
to
cea1a65
Compare
moogacs
force-pushed
the
correct-idx-add-concurrency-properties
branch
from
1b690dc
to
3a30544
Compare
|
reyreaud-l
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's being changed:
revert what was originally was introduced by mistake on
https://github.com/weaviate/weaviate/pull/4535/files#diff-d080e5efa621477a1d974bced14c39a8912fcb7a649eb4a0fb219647728dbc3dL416
Review checklist