Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consistency from tenant get #4859

Merged
merged 2 commits into from
May 7, 2024
Merged

Remove consistency from tenant get #4859

merged 2 commits into from
May 7, 2024

Conversation

dirkkul
Copy link
Contributor

@dirkkul dirkkul commented May 6, 2024

What's being changed:

We don't want to expose this flag to the clients at the moment

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

moogacs
moogacs approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@moogacs moogacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to make sure that proto is backward compatible and we can use reserved fields for this

@dirkkul dirkkul merged commit d23863f into stable/v1.25 May 7, 2024
41 checks passed
@dirkkul dirkkul deleted the tenant_get_consistency branch May 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moogacs moogacs moogacs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dirkkul @moogacs