Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove consistency from tenant get #4859

Merged
merged 2 commits into from
May 7, 2024
Merged

Remove consistency from tenant get #4859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
252bca3
Remove consistency flag from getTenants
dirkkul May 6, 2024
1be8e9d
Fix test
dirkkul May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions adapters/handlers/grpc/v1/tenants.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ func (s *Service) tenantsGet(ctx context.Context, principal *models.Principal, r
var err error
var tenants []*models.Tenant
if req.Params == nil {
tenants, err = s.schemaManager.GetConsistentTenants(ctx, principal, req.Collection, req.IsConsistent, []string{})
tenants, err = s.schemaManager.GetConsistentTenants(ctx, principal, req.Collection, true, []string{})
if err != nil {
return nil, err
}
Expand All @@ -38,7 +38,7 @@ func (s *Service) tenantsGet(ctx context.Context, principal *models.Principal, r
if len(requestedNames) == 0 {
return nil, fmt.Errorf("must specify at least one tenant name")
}
tenants, err = s.schemaManager.GetConsistentTenants(ctx, principal, req.Collection, req.IsConsistent, requestedNames)
tenants, err = s.schemaManager.GetConsistentTenants(ctx, principal, req.Collection, true, requestedNames)
if err != nil {
return nil, err
}
Expand Down
49 changes: 20 additions & 29 deletions grpc/generated/protocol/v1/properties.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

167 changes: 76 additions & 91 deletions grpc/generated/protocol/v1/search_get.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading