Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup:scheduler: compare and error based on major versions only #4925

Merged
merged 2 commits into from
May 15, 2024
Merged

backup:scheduler: compare and error based on major versions only #4925

merged 2 commits into from
May 15, 2024

Conversation

moogacs
Copy link
Contributor

@moogacs moogacs commented May 15, 2024 •
edited
Loading

What's being changed:

the version was changed during raft impl. to 2.1 instead of 2.0 here . this PR change is made to compare major version comparisons only to avoid unnecessarily errors

Review checklist

  • Documentation has been updated, if necessary. Link to changed documentation:
  • Chaos pipeline run or not necessary. Link to pipeline:
  • All new code is covered by tests where it is reasonable.
  • Performance tests have been run or not necessary.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

reyreaud-l
reyreaud-l approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@reyreaud-l reyreaud-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and logical change, we need to ensure that in the future we update these versions the right way :)

@moogacs moogacs changed the title backup:scheduler: compare and error based on major version backup:scheduler: compare and error based on major versions only May 15, 2024
@moogacs moogacs marked this pull request as ready for review May 15, 2024 09:19
@moogacs moogacs merged commit 073654e into stable/v1.24 May 15, 2024
38 of 39 checks passed
@moogacs moogacs deleted the backup-scheduler-comp branch May 15, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyreaud-l reyreaud-l reyreaud-l approved these changes

@antas-marcin antas-marcin antas-marcin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@moogacs @reyreaud-l @antas-marcin