Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add auto highlighter plugin and follow some advice from the rust-analyzer #38

Merged
merged 2 commits into from
May 3, 2024
Merged

feat: add auto highlighter plugin and follow some advice from the rust-analyzer #38

merged 2 commits into from
May 3, 2024

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented May 2, 2024

This plugin is very simple, just to solve this issue web-infra-dev/rspress#1043. I think putting it in plugin_toc may avoid an unnecessary loop operation, but in the end, I decided to add a plugin for future maintenance.
In addition, I also removed some unnecessary code based on the prompts from the rust-analyzer.

@SoonIter
Copy link
Member

SoonIter commented May 3, 2024

LGTM, I think there is also a TODO point that we need to handle the default alias to get better DX

```md
```

```markdown
```

Maybe it is more appropriate to do this work on the js side.
https://github.com/web-infra-dev/rspress/blob/10799e72a7b592898eab5ef0a1cd08adaaf4cf4c/packages/shared/src/runtime-utils/index.ts#L11

@shulaoda
Copy link
Contributor Author

shulaoda commented May 3, 2024

Maybe it is more appropriate to do this work on the js side. https://github.com/web-infra-dev/rspress/blob/10799e72a7b592898eab5ef0a1cd08adaaf4cf4c/packages/shared/src/runtime-utils/index.ts#L11

Yes, I have completed the relevant operations and will submit them later in rspress.

@SoonIter SoonIter merged commit cb40d47 into web-infra-dev:main May 3, 2024
29 checks passed
@shulaoda shulaoda deleted the feat/auto-highlighter-plugin branch May 3, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants