fix: not specify externalsType in rspack mode (#5861)

web-infra-dev · Jun 21, 2024 · ea16092 · ea16092
1 parent a7ee8e0
commit ea16092
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/.changeset/afraid-clocks-kick.md b/.changeset/afraid-clocks-kick.md
@@ -0,0 +1,5 @@
+---
+'@modern-js/plugin-garfish': patch
+---
+
+fix: not specify externalsType in rspack mode
diff --git a/packages/runtime/plugin-garfish/src/cli/index.ts b/packages/runtime/plugin-garfish/src/cli/index.ts
@@ -127,18 +127,6 @@ export const garfishPlugin = ({
                 'Access-Control-Allow-Origin': '*',
               },
             },
-            rspack: (config: any) => {
-              config.builtins ??= {};
-
-              // eslint-disable-next-line react-hooks/rules-of-hooks
-              const resolveOptions = useResolvedConfigContext();
-              if (
-                resolveOptions?.deploy?.microFrontend &&
-                !config.externalsType
-              ) {
-                config.externalsType = 'commonjs';
-              }
-            },
             bundlerChain: (chain, { env, CHAIN_ID, bundler }) => {
               // add comments avoid sourcemap abnormal
               if (bundler.BannerPlugin) {