refactor: remove paranthesis expression #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
force-pushed
the
paranthesis-expression
branch
2 times, most recently
from
8a3d800
to
ef180cd
Compare
Benchmark ResultsLinuxWindows |
Boshen
force-pushed
the
paranthesis-expression
branch
from
ef180cd
to
d25fd4d
Compare
|
I'm working on this in another branch, this is hard than I thought. JavaScript grammar are wild 😭 |
Boshen
force-pushed
the
paranthesis-expression
branch
from
d25fd4d
to
58da061
Compare
Boshen
force-pushed
the
paranthesis-expression
branch
from
58da061
to
f348068
Compare
|
Oh man this took longer than I thought, and I had to juggle a lot of decisions ... This is currently in a mergeable state, where the bulk of the work is done. Once merged, we'll be able to fix all the smaller issues one by one, instead of trying to fix everything altogether. I turned off some of the previous optimizations, because they are interfering with each other. I also turned off some of the tests, because the optimizations aren't done yet. In the next steps, I'll look into the bigger architecture first, mainly separate out the these interfering optimizations into separate ast passes. During the meantime, you guys can pick up any commented out test and try to learn some JavaScript Grammar 😄 |
Boshen
reviewed
Jun 1, 2023
There was a problem hiding this comment.
Things are getting smaller overall! Hooray!
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
==========================================
- Coverage 89.54% 89.42% -0.13%
==========================================
Files 151 151
Lines 28093 28159 +66
==========================================
+ Hits 25156 25181 +25
- Misses 2937 2978 +41
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anonrig
commented
Jun 1, 2023
| @@ -24,7 +25,7 @@ impl<'a> GetPrecedence for Expression<'a> { | |||
| Self::NewExpression(expr) => expr.precedence(), | |||
| Self::CallExpression(expr) => expr.precedence(), | |||
| Self::MemberExpression(expr) => expr.precedence(), | |||
| _ => Precedence::Lowest, | |||
| _ => Precedence::highest(), | |||
There was a problem hiding this comment.
What is the reason for this change? @Boshen
There was a problem hiding this comment.
There was a problem hiding this comment.
The rest are primary expressions, which has the highest precedence.
Brooooooklyn
added a commit
to toeverything/AFFiNE
that referenced
this pull request
Jan 7, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [oxlint](https://oxc-project.github.io) ([source](https://togithub.com/oxc-project/oxc/tree/HEAD/npm/oxlint)) | [`0.0.22` -> `0.1.2`](https://renovatebot.com/diffs/npm/oxlint/0.0.22/0.1.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>oxc-project/oxc (oxlint)</summary> ### [`v0.1.2`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.1.2): oxlint v0.1.2 [Compare Source](https://togithub.com/oxc-project/oxc/compare/821cc8e9c7cfb326ff546483bb2a32d12e018e4c...4a9e0c4bf4179bf5839b690be3690163ff00e2ef) #### Try it out! - Run `npx --yes oxlint@latest` from your terminal - Install the Vscode extension https://marketplace.visualstudio.com/items?itemName=oxc.oxc-vscode - Read the [usage guide](https://oxc-project.github.io/docs/guide/usage/linter.html) #### Svelte support `<script>` tag is linted by default. #### Features - feat(linter): <script> part of svelte file by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#1918 - feat(linter): disable no-unused-labels for svelte by [@​Boshen](https://togithub.com/Boshen) in [oxc-project/oxc#1919 ### Fixes - fix(linter): change no-var to restriction [`bb6128b`](https://togithub.com/oxc-project/oxc/commit/bb6128b) - chore: add some useful informantion log by [@​IWANABETHATGUY](https://togithub.com/IWANABETHATGUY) in [oxc-project/oxc#1912 - fix(linter) fix eslint config for filename case by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1913 **Full Changelog**: oxc-project/oxc@oxlint_v0.1.1...oxlint_v0.1.2 ### [`v0.1.1`](https://togithub.com/oxc-project/oxc/releases/tag/oxlint_v0.1.1): oxlint v0.1.1 [Compare Source](https://togithub.com/oxc-project/oxc/compare/v0.1.0...821cc8e9c7cfb326ff546483bb2a32d12e018e4c) #### Try it out! - Run `npx --yes oxlint@latest` from your terminal - Install the Vscode extension https://marketplace.visualstudio.com/items?itemName=oxc.oxc-vscode - Read the [usage guide](https://oxc-project.github.io/docs/guide/usage/linter.html) #### Vue support `<script>` and `<script setup>` are linted by default. #### Astro support Frontmatter component script `---` and all `<script>` tags are linted by default. #### Configuration files (experimental) `-c ./eslintrc.json` will use the `rules` field for rule configuration, as documented in [ESLint's documentation](https://eslint.org/docs/latest/use/configure/rules#using-configuration-files). Unfortunately, only the `json` format is supported right now. The `extends` field will not take effect; normal `-D` and `-A` flags still apply. #### New Rules ##### Correctness - deepscan: bad object literal comparison by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1844 - oxc: erasing op by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1834 - oxc: only used in recursion by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1833 - eslint: no irregular whitespace by [@​DeividAlmeida](https://togithub.com/DeividAlmeida) in [oxc-project/oxc#1877 - eslint: no-unused-private-class-members rule by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#1820 - eslint: no-var by [@​zhangrunzhao](https://togithub.com/zhangrunzhao) in [oxc-project/oxc#1890 - eslint-plugin-react: jsx-no-undef for by [@​XantreGodlike](https://togithub.com/XantreGodlike) in [oxc-project/oxc#1862 - eslint-plugin-jsx-a11y: aria-role by [@​msdlisper](https://togithub.com/msdlisper) in [oxc-project/oxc#1849 - eslint-plugin-jsx-a11y: lang by [@​msdlisper](https://togithub.com/msdlisper) in [oxc-project/oxc#1812 - eslint-plugin-jsx-a11y: media-has-caption by [@​poteboy](https://togithub.com/poteboy) in [oxc-project/oxc#1822 - eslint-plugin-jsx-a11y: mouse-events-have-key-events(correctness) by [@​Ken-HH24](https://togithub.com/Ken-HH24) in [oxc-project/oxc#1867 - eslint-plugin-jsx-a11y: prefer-tag-over-role rule by [@​yossydev](https://togithub.com/yossydev) in [oxc-project/oxc#1831 - eslint-plugin-jsx-a11y: aria-unsupported-elements by [@​re-taro](https://togithub.com/re-taro) in [oxc-project/oxc#1855 - eslint-plugin-jsx-a11y: html_has_lang by [@​msdlisper](https://togithub.com/msdlisper) in [oxc-project/oxc#1843 ##### Suspicious - oxc: approx constant by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1818 - oxc: misrefactored assign op by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1832 ##### Restriction - react: button has type by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1785 - unicorn: prefer modern math apis by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1620 #### Fixes - fix(linter): ignore anonymous functional components in arrays for eslint-plugin-react(jsx-key) by [@​maurice](https://togithub.com/maurice) in [oxc-project/oxc#1858 - Prioritize ignored paths when linting by [@​clarkf](https://togithub.com/clarkf) in [oxc-project/oxc#1878 - feat(linter): handle more cases for `const-comparisons` by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1817 - feat(semantic): allow reserved keyword defined in ts module block by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#1907 - fix(parser): error on source larger than 4 GiB by [@​overlookmotel](https://togithub.com/overlookmotel) in [oxc-project/oxc#1860 - fix(parser): fix incorrectly identified directives by [@​overlookmotel](https://togithub.com/overlookmotel) in [oxc-project/oxc#1885 - fix(parser): terminate parsing if an EmptyParenthesizedExpression error occurs by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#1874 - fix(semantic): remove duplicate errors in ModuleDeclaration::ImportDeclaration by [@​Dunqing](https://togithub.com/Dunqing) in [oxc-project/oxc#1846 - perf(linter): reduce the number of diagnostics for no_sparse_arrays by [@​camc314](https://togithub.com/camc314) in [oxc-project/oxc#1895 #### New Contributors - [@​maurice](https://togithub.com/maurice) made their first contribution in [oxc-project/oxc#1858 - [@​re-taro](https://togithub.com/re-taro) made their first contribution in [oxc-project/oxc#1855 - [@​DeividAlmeida](https://togithub.com/DeividAlmeida) made their first contribution in [oxc-project/oxc#1835 - [@​XantreGodlike](https://togithub.com/XantreGodlike) made their first contribution in [oxc-project/oxc#1862 - [@​Qix-](https://togithub.com/Qix-) made their first contribution in [oxc-project/oxc#1861 - [@​yossydev](https://togithub.com/yossydev) made their first contribution in [oxc-project/oxc#1831 - [@​clarkf](https://togithub.com/clarkf) made their first contribution in [oxc-project/oxc#1878 - [@​zhangrunzhao](https://togithub.com/zhangrunzhao) made their first contribution in [oxc-project/oxc#1890 **Full Changelog**: oxc-project/oxc@oxlint_v0.0.22...oxlint_v0.1.1 ### [`v0.1.0`](https://togithub.com/oxc-project/oxc/releases/tag/v0.1.0): CLI v0.1.0 Ezno Type Checker [Compare Source](https://togithub.com/oxc-project/oxc/compare/a1accdca7f83694a6ea520d5cbfd090ea5dd271a...v0.1.0) `npx oxidation-compiler@latest check ./test.ts`  #### New Contributors - [@​anonrig](https://togithub.com/anonrig) made their first contribution in [oxc-project/oxc#388 - [@​kaleidawave](https://togithub.com/kaleidawave) made their first contribution in [oxc-project/oxc#413 **Full Changelog**: https://github.com/Boshen/oxc/compare/v0.0.7... </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/toeverything/AFFiNE). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjEyMS4wIiwidGFyZ2V0QnJhbmNoIjoiY2FuYXJ5In0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Fixes #384