Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 馃 webpack test case #2544

Merged
merged 17 commits into from
Mar 30, 2023
Merged

chore: 馃 webpack test case #2544

merged 17 commits into from
Mar 30, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Mar 29, 2023 •
edited

Summary

  1. rename the config test snapshot test .bak or jest will complain about this:
    image
    webpack-test/__snapshots__/ConfigTestCases.basictest.js.snap.bak
  2. progressive add test case, for we only run webpack-test/configCases/defaulter/immutable-config/test.filter.js

How to test

  1. pull this branch.
  2. cd webpack-test
  3. pnpm t

Related issue (if exists)

  1. Closed Make basic webpack configCase run with the minimum modification.聽#2563

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023 •
edited

鈿狅笍 No Changeset found

Latest commit: 416246c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@IWANABETHATGUY IWANABETHATGUY changed the title chore: 馃 test case chore: 馃 webpack test case Mar 29, 2023
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 29, 2023
@IWANABETHATGUY IWANABETHATGUY mentioned this pull request Mar 30, 2023
Merged
7 tasks
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/webpack-test-case branch 2 times, most recently from 6af3f8b to eb01162 Compare March 30, 2023 08:09
@IWANABETHATGUY IWANABETHATGUY marked this pull request as ready for review March 30, 2023 11:56
@IWANABETHATGUY IWANABETHATGUY added this pull request to the merge queue Mar 30, 2023
Merged via the queue into main with commit aa9d740 Mar 30, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the chore/webpack-test-case branch March 30, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make basic webpack configCase run with the minimum modification.
2 participants
@IWANABETHATGUY @hardfist