Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 馃 migrate test from webpack #2550

Merged
merged 1 commit into from
Mar 30, 2023
Merged

chore: 馃 migrate test from webpack #2550

merged 1 commit into from
Mar 30, 2023

Conversation

IWANABETHATGUY
Copy link
Contributor

@IWANABETHATGUY IWANABETHATGUY commented Mar 30, 2023 •
edited

Summary

  1. This pull request is just a Ctrl+c and Ctrl+v of test directory of webpack. This pr is part of chore: 馃 webpack test case聽#2544, because that pr has more than 5000+ files that are impossible to review in the browser.

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023 •
edited

鈿狅笍 No Changeset found

Latest commit: 3f66b57

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Mar 30, 2023
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/basic-migrate-webpack-test branch from b111ee3 to 2ad74ea Compare March 30, 2023 06:23
@IWANABETHATGUY IWANABETHATGUY force-pushed the chore/basic-migrate-webpack-test branch from 2ad74ea to 3f66b57 Compare March 30, 2023 06:29
@hyf0
Copy link
Collaborator

hyf0 commented Mar 30, 2023

Could ignore these files in .gitattributes just like what SWC did in https://github.com/swc-project/swc/blob/44062d6fa536af0e3a3e38e6d17fb43763d627bb/.gitattributes#L13-L14

@IWANABETHATGUY
Copy link
Contributor Author

gitattributes

Done

@IWANABETHATGUY IWANABETHATGUY merged commit 1f1e267 into main Mar 30, 2023
@IWANABETHATGUY IWANABETHATGUY deleted the chore/basic-migrate-webpack-test branch March 30, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

Assignees
No one assigned
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IWANABETHATGUY @hyf0 @hardfist