Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): support mjs&cjs as default config file #2685

Merged
merged 2 commits into from
Apr 10, 2023
Merged

feat(cli): support mjs&cjs as default config file #2685

merged 2 commits into from
Apr 10, 2023

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 10, 2023

Summary

since we support mjs as config file now, we should support rspack.config.mjs as default config file

Related issue (if exists)

Types of changes

  • Docs change / Dependency upgrade
  • Bug fix
  • New feature / Improvement
  • Refactoring
  • Breaking change

Checklist

  • I have added changeset via pnpm run changeset.
  • I have added tests to cover my changes.

@changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2023

🦋 Changeset detected

Latest commit: 1d4aeaf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@rspack/cli Patch
benchmarkcase-rspack-react-refresh Patch
@rspack/playground Patch
@rspack/postcss-loader Patch
@rspack/dev-client Patch
@rspack/dev-middleware Patch
@rspack/dev-server Patch
@rspack/plugin-html Patch
@rspack/plugin-minify Patch
@rspack/plugin-node-polyfill Patch
@rspack/core Patch
@rspack/binding-darwin-arm64 Patch
@rspack/binding-darwin-x64 Patch
@rspack/binding-linux-x64-gnu Patch
@rspack/binding-win32-x64-msvc Patch
@rspack/binding Patch
@rspack/fs Patch
webpack-test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hardfist hardfist changed the title feat: support mjs as default config file feat(cli): support mjs as default config file Apr 10, 2023
@hyf0 hyf0 added this to the [Feature Request]: Support esm exports for config files milestone Apr 10, 2023
@hyf0 hyf0 modified the milestones: [Feature Request]: Support esm exports for config files, Next patch release - 0.1.X Apr 10, 2023
@hyf0 hyf0 linked an issue Apr 10, 2023 that may be closed by this pull request
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 10, 2023
chenjiahan
chenjiahan previously approved these changes Apr 10, 2023
@hardfist hardfist changed the title feat(cli): support mjs as default config file feat(cli): support mjs&cjs as default config file Apr 10, 2023
@hardfist hardfist enabled auto-merge April 10, 2023 09:56
@hardfist hardfist added this pull request to the merge queue Apr 10, 2023
Merged via the queue into main with commit 9f9c280 Apr 10, 2023
6 checks passed
@hardfist hardfist deleted the mjs-config branch April 10, 2023 13:20
@github-actions github-actions bot mentioned this pull request Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Support esm exports for config files
4 participants