Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Support esm exports for config files #2668

Closed
RobinClowers opened this issue Apr 7, 2023 · 3 comments · Fixed by #2685
Closed

[Feature Request]: Support esm exports for config files #2668

RobinClowers opened this issue Apr 7, 2023 · 3 comments · Fixed by #2685
Labels
feat New feature or request good first issue Good for newcomers

Comments

@RobinClowers
Copy link

What problem does this feature solve?

Typescript and node support esm, and it's confusing that the config file requires using a commonjs export.

What does the proposed API of configuration look like?

Rspack should look for a default export first, and fall back to using the named exports if it doesn't find the default export.

@RobinClowers RobinClowers added the feat New feature or request label Apr 7, 2023
@hyf0 hyf0 added p3-nice-to-have good first issue Good for newcomers and removed needs-triage labels Apr 7, 2023
@hyf0 hyf0 added this to the Planned milestone Apr 7, 2023
@hardfist
Copy link
Contributor

hardfist commented Apr 7, 2023

@RobinClowers
Copy link
Author

Oh cool, I will try that out! Seems like it needs to be added to the docs, unless I missed it?

@hyf0
Copy link
Collaborator

hyf0 commented Apr 10, 2023

Closed for having web-infra-dev/rspack-website#267.

@hyf0 hyf0 closed this as completed Apr 10, 2023
@hyf0 hyf0 linked a pull request Apr 10, 2023 that will close this issue
7 tasks
@hyf0 hyf0 modified the milestones: Planned, Working in progress Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants