Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix type checking in config examples #2965

Merged
merged 2 commits into from
Apr 28, 2023
Merged

fix: Fix type checking in config examples #2965

merged 2 commits into from
Apr 28, 2023

Conversation

danielkoller
Copy link
Contributor

@danielkoller danielkoller commented Apr 27, 2023

Hello there!

Thanks for rspack!

Just a quick PR to fix the type checking in the configuration file examples you have, similar to the config page.

It was already discussed and merged here.

The underlying TypeScript problem is found here.

Thanks to @karlhorky for letting me take this over.

@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: 8bfbf1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

@danielkoller danielkoller changed the title Fix type checking in config examples Fix: Fix type checking in config examples Apr 27, 2023
@danielkoller danielkoller changed the title Fix: Fix type checking in config examples fix Fix type checking in config examples Apr 27, 2023
@danielkoller danielkoller changed the title fix Fix type checking in config examples fix: Fix type checking in config examples Apr 27, 2023
@hyf0
Copy link
Collaborator

hyf0 commented Apr 28, 2023

Thank you! I've changed rspack.config.js of my Rspack template following this PR :).

@hyf0 hyf0 added this pull request to the merge queue Apr 28, 2023
Merged via the queue into web-infra-dev:main with commit fe6d564 Apr 28, 2023
IWANABETHATGUY pushed a commit that referenced this pull request Apr 28, 2023
* Fix type checking in config examples

* Update rspack.config.js
siyou pushed a commit to siyou/rspack that referenced this pull request May 14, 2023
* Fix type checking in config examples

* Update rspack.config.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants