Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): support pass false to plugins #4949

Merged
merged 10 commits into from
Dec 12, 2023
Merged

fix(config): support pass false to plugins #4949

Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
c1b5f6a
fix(config): support pass false to plugins
puppet-666 Dec 8, 2023
e47e8ea
fix: prettier format
puppet-666 Dec 8, 2023
c4dac9c
test(config): support pass false to plugins
puppet-666 Dec 8, 2023
83bacb3
fix(test): support pass false to plugins
puppet-666 Dec 8, 2023
c18a1ad
fix(config): support falsy
puppet-666 Dec 8, 2023
c131bfb
fix: zod falsy type
puppet-666 Dec 12, 2023
9e9d673
fix: zod falsy string init value
puppet-666 Dec 12, 2023
980a798
fix: Temporarily remove support for falsy in rules
puppet-666 Dec 12, 2023
7326737
fix: minimizer apply
puppet-666 Dec 12, 2023
b2db972
fix: falsy test
puppet-666 Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/rspack/src/rspack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@ function createCompiler(userOptions: RspackOptions): Compiler {
for (const plugin of options.plugins) {
if (typeof plugin === "function") {
(plugin as RspackPluginFunction).call(compiler, compiler);
} else if (typeof plugin === "boolean") {
puppet-666 marked this conversation as resolved.
Show resolved Hide resolved
continue;
} else {
plugin.apply(compiler);
}
Expand Down Expand Up @@ -148,8 +150,10 @@ function rspack(
} else {
const { compiler, watch } = create();
if (watch) {
util.deprecate(() => {},
"A 'callback' argument needs to be provided to the 'rspack(options, callback)' function when the 'watch' option is set. There is no way to handle the 'watch' option without a callback.")();
util.deprecate(
() => {},
"A 'callback' argument needs to be provided to the 'rspack(options, callback)' function when the 'watch' option is set. There is no way to handle the 'watch' option without a callback."
)();
}
return compiler;
}
Expand Down
Loading