-
-
Notifications
You must be signed in to change notification settings - Fork 559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): support pass false to plugins #4949
Conversation
@puppet-666 please sign the cla |
done |
https://web-infra-dev.github.io/rspack-dev-guide/testing/intro.html @puppet-666 you can read this about how rspack test |
Thanks for your answer. Are test cases required for this merge? If so I will add test cases |
@puppet-666 I think we should align this with webpack and allow all falsy value here, you can take webpack/webpack#17339 for reference(no need to support falsy value for loader in this PR) |
@hardfist
|
thanks! |
* fix(config): support pass false to plugins * fix: prettier format * test(config): support pass false to plugins * fix(test): support pass false to plugins * fix(config): support falsy * fix: zod falsy type * fix: zod falsy string init value * fix: Temporarily remove support for falsy in rules * fix: minimizer apply * fix: falsy test
Summary
To support pass false to plugins
resolve #4939
resolve #4926
Test Plan
This is my first time contributing to rspack. At present, I only know how to create tests in the 'packages \ rspack \ tests \ configCases' directory, but I am not very familiar with the running logic of test cases. Can you give me some help?
Require Documentation?