Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate swc-loader cases #6114

Merged
merged 2 commits into from
Apr 7, 2024
Merged

chore: migrate swc-loader cases #6114

merged 2 commits into from
Apr 7, 2024

Conversation

LingyuCoder
Copy link
Collaborator

@LingyuCoder LingyuCoder commented Apr 3, 2024 •
edited

Summary

  • move test cases to rspack-test-tools/tests/buildinCases
  • modify test.config.json to test.config.js
  • remove directory expected, just use snapshot
  • remove unused test cases
  • snapshot should not be changed, expect hashes

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from h-a-n-a April 3, 2024 14:18
@netlify Netlify
Copy link

netlify bot commented Apr 3, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 62f7ca2
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/660d8bdf141c640008cb8998

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 3, 2024
@LingyuCoder LingyuCoder marked this pull request as draft April 3, 2024 14:19
@LingyuCoder LingyuCoder changed the title chore migrate builtin swc-loader cases chore migrate builtin cases(part 1) Apr 3, 2024
@LingyuCoder LingyuCoder changed the title chore migrate builtin cases(part 1) chore: migrate builtin cases(part 1) Apr 3, 2024
@LingyuCoder LingyuCoder changed the title chore: migrate builtin cases(part 1) chore: migrate builtin cases Apr 3, 2024
@LingyuCoder LingyuCoder changed the title chore: migrate builtin cases chore: migrate builtin cases (swc-loader) Apr 3, 2024
@LingyuCoder LingyuCoder force-pushed the chore/migrate-swc-loader-cases branch from 6a7538e to 62f7ca2 Compare April 3, 2024 17:03
@LingyuCoder LingyuCoder marked this pull request as ready for review April 3, 2024 17:07
@LingyuCoder LingyuCoder mentioned this pull request Apr 3, 2024
Merged
2 tasks
@LingyuCoder LingyuCoder changed the title chore: migrate builtin cases (swc-loader) chore: migrate swc-loader cases Apr 3, 2024
This was referenced Apr 3, 2024
Merged
Merged
Merged
Merged
Merged
@LingyuCoder LingyuCoder merged commit 2d6be0d into main Apr 7, 2024
32 checks passed
@LingyuCoder LingyuCoder deleted the chore/migrate-swc-loader-cases branch April 7, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@h-a-n-a h-a-n-a Awaiting requested review from h-a-n-a

Assignees

@LingyuCoder LingyuCoder

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LingyuCoder @hardfist