Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove rspack testing dependency #6121

Merged
merged 3 commits into from
Apr 7, 2024
Merged

chore: remove rspack testing dependency #6121

merged 3 commits into from
Apr 7, 2024

Conversation

LingyuCoder
Copy link
Collaborator

Summary

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 3, 2024
This was referenced Apr 3, 2024
Merged
Merged
Merged
Merged
@LingyuCoder
Copy link
Collaborator Author

LingyuCoder commented Apr 3, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LingyuCoder and the rest of your teammates on Graphite Graphite

@LingyuCoder LingyuCoder mentioned this pull request Apr 3, 2024
Merged
2 tasks
@LingyuCoder
Copy link
Collaborator Author

!diff

@LingyuCoder LingyuCoder force-pushed the chore/migrate-plugin-json-wasm-cases branch from 3f17fa4 to a1e3626 Compare April 7, 2024 05:16
@LingyuCoder LingyuCoder force-pushed the chore/remove-rspack-testing-dependency branch from 41ccec9 to bfd1683 Compare April 7, 2024 05:16
Base automatically changed from chore/migrate-plugin-json-wasm-cases to main April 7, 2024 05:44
@LingyuCoder LingyuCoder force-pushed the chore/remove-rspack-testing-dependency branch from bfd1683 to 3eeb6dc Compare April 7, 2024 05:58
@netlify Netlify
Copy link

netlify bot commented Apr 7, 2024 •
edited

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3eeb6dc
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/661235eb8b74a100088faee5

@LingyuCoder LingyuCoder marked this pull request as ready for review April 7, 2024 06:13
@LingyuCoder LingyuCoder merged commit 6e4d475 into main Apr 7, 2024
28 checks passed
@LingyuCoder LingyuCoder deleted the chore/remove-rspack-testing-dependency branch April 7, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardfist hardfist hardfist approved these changes

@ahabhgk ahabhgk Awaiting requested review from ahabhgk

@jerrykingxyz jerrykingxyz Awaiting requested review from jerrykingxyz jerrykingxyz is a code owner

Assignees

@LingyuCoder LingyuCoder

Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LingyuCoder @hardfist