Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(theme-default): sidebar incorrect active #993

Merged
merged 2 commits into from
Apr 22, 2024
Merged

fix(theme-default): sidebar incorrect active #993

merged 2 commits into from
Apr 22, 2024

Conversation

shulaoda
Copy link
Contributor

@shulaoda shulaoda commented Apr 20, 2024 •
edited by Timeless0911
Loading

Summary

修复默认模版中 siderbar active 不正确问题

Related Issue

closes: #991

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited
Loading

✅ Deploy Preview for aquamarine-blini-95325f ready!

Name Link
🔨 Latest commit be7ae78
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-blini-95325f/deploys/66260ae8ce8d890008f5e5a4
😎 Deploy Preview https://deploy-preview-993--aquamarine-blini-95325f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 86 (🔴 down 7 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@shulaoda shulaoda mentioned this pull request Apr 20, 2024
Closed
@Timeless0911
Copy link
Collaborator

LGTM, thank you~

@Timeless0911 Timeless0911 enabled auto-merge (squash) April 22, 2024 08:48
@Timeless0911 Timeless0911 merged commit 0ce99c6 into web-infra-dev:main Apr 22, 2024
9 checks passed
@shulaoda shulaoda deleted the fix/default-theme-sidebar branch April 22, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timeless0911 Timeless0911 Timeless0911 approved these changes

Assignees
No one assigned
Labels
change: fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: 默认模版中 Siderbar active 不正确问题
2 participants
@shulaoda @Timeless0911