New object-view-box feature #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
feature definition
ddbeck
reviewed
Jun 14, 2024
| description: The `object-view-box` CSS property defines the subset within an image that should be drawn in the content box of the image. | ||
| spec: https://drafts.csswg.org/css-images-5/#the-object-view-box | ||
| compat_features: | ||
| - css.properties.object-view-box |
There was a problem hiding this comment.
Should the descendant key css.properties.object-view-box.none be a part of this? If not, why not?
There was a problem hiding this comment.
none is the initial value of the property and does nothing. I would expect any browser that supports object-view-box to also support the none value, from the get go.
I think it would be more interesting to add the inset and rect value types once they get added to BCD (I'll take a look and open a PR in BCD for it).
There was a problem hiding this comment.
OK, that's fine. I suspect we may end up tagging none into this feature as well (and the other values, as they get added) as we merge the tools to consume BCD more comprehensively, but this is fine for now. Thank you!
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
ddbeck
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.