Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Keyboard interface feature #1386

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Adding Keyboard interface feature #1386

merged 7 commits into from
Jul 18, 2024

Conversation

tropicadri
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Jul 11, 2024
@foolip
Copy link
Collaborator

foolip commented Jul 12, 2024

@tropicadri can you split this into two features, one for navigator.keyboard.lock() (https://wicg.github.io/keyboard-lock/) and another for navigator.keyboard.getLayoutMap() (https://wicg.github.io/keyboard-map/)? Even though they shipped around the same time in Chrome, they have distinct use cases. Describing them is probably easier as separate features.

@tropicadri
Copy link
Collaborator Author

@foolip done the splitting thanks!

foolip
foolip approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some description suggestions, but the feature groups are exactly what I had in mind, and the computed statuses too.

features/keyboard-lock.yml Outdated Show resolved Hide resolved
features/keyboard-map.yml Outdated Show resolved Hide resolved
tropicadri and others added 3 commits July 17, 2024 09:55
@tropicadri @foolip
Update features/keyboard-lock.yml
dc9f00d 
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@tropicadri @foolip
Update features/keyboard-map.yml
10ed02e 
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
@tropicadri
Merge branch 'main' into keyboard-lock
489f385
@foolip foolip merged commit 3c52db0 into web-platform-dx:main Jul 18, 2024
3 checks passed
petele pushed a commit to petele/web-features that referenced this pull request Jul 18, 2024
@tropicadri @foolip @petele
Adding Keyboard interface feature (web-platform-dx#1386)
103b926 
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tropicadri @foolip